Skip to content

fix(react-query): update use-sync-external-store to support React 19 as peerDep correctly #10039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manudeli wants to merge 2 commits into
base: v4
Choose a base branch
from
Open

fix(react-query): update use-sync-external-store to support React 19 as peerDep correctly #10039

manudeli wants to merge 2 commits into from
+34 −226

Conversation

@manudeli
Copy link
Collaborator

@manudeli manudeli commented Jan 14, 2026 •
edited
Loading

Issued by @gronxb

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: b7ef031

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tanstack/react-query Patch
@tanstack/react-query-devtools Patch
@tanstack/react-query-persist-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 14, 2026 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7ef031:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@manudeli manudeli force-pushed the fix/use-sync-external-store-version-up-for-peer branch from 56d74a3 to cfa76c0 Compare January 14, 2026 14:53
@manudeli manudeli self-assigned this Jan 14, 2026
@manudeli manudeli force-pushed the fix/use-sync-external-store-version-up-for-peer branch from cfa76c0 to f6fa850 Compare January 17, 2026 02:44
@nx-cloud
Copy link

nx-cloud bot commented Jan 17, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b7ef031

Command Status Duration Result
nx affected --targets=test:lib,test:types,test:... ✅ Succeeded 3s View ↗
nx affected --targets=test:lib --base=5b7fad487... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-17 02:50:21 UTC

@manudeli manudeli marked this pull request as ready for review January 17, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@manudeli manudeli

Labels

package: react-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manudeli